Support for affine images and store colocation #74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elliottslaughter
pushed a commit
to elliottslaughter/legate
that referenced
this pull request
Mar 26, 2025
* Avoid using naked LogicalRegionField* * Remove unmapping from the public API * Move unmapping to root LogicalRegionField destructor * Using non-literal strings as format strings produces security warning * Print out compile_commands.json for C++ tests, to aid clangd * Fix typo * Wait for inline mapped PhysicalRegion to become valid before returning * Set provenance on InlineLauncher * Support for attach and detach * Testcase for attach * Fix ordering of dimensions * Small test system improvements * Fix collective= argument * Properly test out-of-order-destroyed stores, fix related bugs * Process review comments from nv-legate#57 * Address review comments * Add negative tests, add missing unbound() check on detach * Give share and ordering args defaults
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes two changes: 1) support for affine image partitions, and 2) a mapper update for store colocation.